fix: verify spruce binary checksum during installation - #2343
Open
paramcodes wants to merge 1 commit into
Open
Conversation
Verify the downloaded Spruce binary against its published SHA-1 checksum before placing it in the target directory and marking it executable. Add regression tests covering valid checksums, checksum mismatches, Darwin shasum usage, and missing checksum assets. Fixes shipwright-io#2328 Signed-off-by: paramcodes <sparamveer1001@gmail.com>
pull-request-size
Bot
added
the
size/L
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
do-not-merge/release-note-label-needed
openshift-ci
Bot
added
release-note-none
Author
|
@kaizakin can you review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR resolves #2328 by verifying the Spruce binary against its published SHA-1 checksum during installation before placing it at the target path or making it executable.
Details
hack/install-spruce.sh:.sha1checksum release assets.null.aarch64->arm64,x86_64->amd64).mktemp) with anEXITtrap for cleanup.sha1sum --checkon Linux andshasum --algorithm 1 --checkon Darwin.${TARGET_DIR}/spruceand setschmod a+rx.hack/install-spruce_test.sh:Makefile:test-install-sprucetarget..github/workflows/verify.yaml:test-install-sprucestep to the Verify workflow.Related Issue
Fixes #2328
Type of PR
/kind bug
Submitter Checklist
Release Notes